Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in OpenXR depth buffer submission #69648

Merged

Conversation

BastiaanOlij
Copy link
Contributor

This typo resulted in the left eye depth buffer being submitted for the right eye causing weird visual glitches in reprojections

@BastiaanOlij BastiaanOlij added this to the 4.0 milestone Dec 6, 2022
@BastiaanOlij BastiaanOlij self-assigned this Dec 6, 2022
@BastiaanOlij BastiaanOlij mentioned this pull request Dec 6, 2022
24 tasks
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs rebase to fix CI, we had a temporary build issue.

@BastiaanOlij BastiaanOlij force-pushed the fix_openxr_depthbuffer_submission branch from d362359 to a35d792 Compare December 6, 2022 10:31
@akien-mga akien-mga merged commit 49e27ce into godotengine:master Dec 6, 2022
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_openxr_depthbuffer_submission branch December 12, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants