Remove high quality glow as it is not any higher quality than regular glow #70009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #70003 I noticed that the high quality glow mode is actually no longer needed since we switched to this optimized compute shader-based glow. The low quality mode already samples all the pixels from the previous mip level. The high quality mode actually made the effect look worse and take 2X as long since it doubled the pixel samples, but just read the extra pixels from a fixed offset.
I originally tried to "fix" high quality mode, but there is no way to make it not broken its just needlessly taking extra samples.
Marked as breaking compatibility because users may be using the functions to set the quality manually. I would prefer to remove everything as I have, but if we want to avoid breaking compatibility, I can mark the setting and functions as deprecated and just make them do nothing.
"Low quality" mode
"High Quality" enabled: notice how the glow looks lopsided
These next images are pretty much worse case scenario for glow as they contain one pixel aliased lines. Capturing fine features like this was the reason we added the high quality mode in the first place.
"Low quality" mode
"High Quality" enabled: There is a very slight shift of strength to the upper left, but it is almost impossible to see without an image diff tool