-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Split node_3d_editor_plugin in multiple files #70283
base: master
Are you sure you want to change the base?
Refactor: Split node_3d_editor_plugin in multiple files #70283
Conversation
Does someone know why the CI static checks fail on this? -/*************************************************************************/
+/*************************************************************************/ |
@quentinguidee there's some weird junk at the beginning of the deleted line: From `hexdump -Cv':
I have no idea why the stuff marked as Edit: |
Ok update: I used a fancy website and that's actually a single character: I should really learn to "decode" utf8 from hexdumps sometime. |
Thanks for your help! With this I found that JetBrains uses UTF-8 with what internet call "BOM" (UTF-8 BOM). I'll try to push the same code in 5min with UTF-8 classic to see if it fixes this. Edit: let's see... |
fef7899
to
ce8bf35
Compare
Uh, the infamous BOM. Looking online, I found why it parsed as a ZWNBSP: From https://en.wikipedia.org/wiki/Zero_width_no-break_space
Damn you BOM! Edit: yup, can confirm that it is indeed |
5da2d5f
to
da2c82a
Compare
Thanks! Static checks pass. Now let's face some fun compiling issues 😑 |
Signed-off-by: Quentin Guidée <[email protected]>
da2c82a
to
ae8bb8a
Compare
Ok, Seems ready for review now. |
I would like to make some improvements this week to the 3D viewport.
However, the
node_3d_editor_plugin
contains a lot of "unrelated" things, which led to 8780 lines, way too much to work properly.This file containing 7 classes with an header of 950 lines, this PR split in 7 files, as advised in this issue: #33027 (comment) (3.).
Feel free to point out things to improve.
I have not edited any methods for this PR to simplify the review, except for the constants that I had to move to
Node3DEditor
.