Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Avoid color flash on window resizing #71295

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 12, 2023

Depends on #71289

Adds macOS implementation.

@bruvzg bruvzg marked this pull request as ready for review January 13, 2023 06:12
@bruvzg bruvzg requested a review from a team as a code owner January 13, 2023 06:12
@akien-mga akien-mga merged commit 04bee38 into godotengine:master Jan 13, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the macos_bg_color branch January 13, 2023 09:06
@RandomShaper
Copy link
Member

This is amazing. Gives me a great feeling of collaboration.

@akien-mga
Copy link
Member

Now we need a hero to save poor old X11 (KDE Plasma / KWin X11, Mesa 22.3, Intel HD 630) 🥺

simplescreenrecorder-2023-01-13_12.43.39.mp4

@RandomShaper
Copy link
Member

I may try myself. I'm working on Godot for X11 for some other bug. No promise. 🙂

@bruvzg
Copy link
Member Author

bruvzg commented Jan 13, 2023

I have tried ro implement it on X11, seems like setting window background pixel fix the transparent parts on startup, but cause blinking on the resize (whole window is filled with bg color every other frame), so no idea how to do it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants