C#: Add missing Transform{2D,3D} and Basis constructors
#71445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was added by mistake / without approval from the core team, so I would remove the C# one that nobody ever requested instead. See context: 676710f#r143530753 |
raulsntos
force-pushed
the
dotnet/transforms
branch
from
7551786
to
e1d6765
Compare
raulsntos
changed the title
Transform{2D,3D} and Basis constructorsTransform{2D,3D} and Basis constructors
kleonc
reviewed
Jan 15, 2023
raulsntos
force-pushed
the
dotnet/transforms
branch
from
e1d6765
to
a899a1e
Compare
kleonc
requested changes
Jan 15, 2023
- Remove `Transform3D(Quaternion, Vector3)` constructor from C#. - Add `Transform3D(Projection)` constructor to C#. - Add documentation to the `Transform3D(Projection)` constructor in Core. - Add `Transform3D` constructor with only real_t params to C# that mirrors `Transform2D`. - Expose `Basis` constructor with only real_t params in C#. - Add `Transform2D(real_t, Vector2, real_t, Vector2)` constructor to C#.
raulsntos
force-pushed
the
dotnet/transforms
branch
from
a899a1e
to
5136366
Compare
kleonc
approved these changes
Jan 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform3D(Quaternion, Vector3)constructor from C#.Transform3D(Projection)constructor to C#.Transform3D(Projection)constructor in Core.Transform3Dconstructor with only real_t params to C# that mirrorsTransform2D.Basisconstructor with only real_t params in C#.Transform2D(real_t, Vector2, real_t, Vector2)constructor to C#.