Disable NVIDIA's threaded OpenGL optimization on Windows #71472

EIREXE · 2023-01-15T18:13:25Z

Disables NVIDIA's threaded optimization which causes random stuttering on Windows with NVIDIA GPUs, virtually all performant OpenGL programs (like ryujinx) disable this to prevent stuttering and it's a well documented issue.

Should fix #33969

Production edit: This closes nVidia "Threaded Optimization" Driver Setting Intefering with Godot Preload Capabilities #45660.

thirdparty/README.md

platform/windows/gl_manager_windows.cpp

EIREXE · 2023-01-15T19:00:38Z

@bruvzg Should be OK now, I also added a fallback profile name for use in the Project Manager

clayjohn · 2023-01-16T18:55:30Z

Seems like a shame to add 25,000 lines of code to disable a driver setting only on one brand of GPUs, but looking at the build artifacts, overall size has changed by less than 1 mb (the size for windows build artifacts in this PR are reported at the same size as master) so maybe it isn't a big deal

aaronfranke · 2023-01-16T19:02:35Z

Why does disabling a driver setting require 25k lines of third-party code?

EIREXE · 2023-01-16T19:53:13Z

Why does disabling a driver setting require 25k lines of third-party code?

ask nvidia, although we could just copy some nvidia types over and use only those

Riteo · 2023-01-17T06:21:36Z

@EIREXE would it be possible (aka without too much trouble) to trim everything that isn't the threaded optimization part from the thirdparty code or is it too jumbled up for that?

I can't imagine that most big graphics programs just import this huge gigantic 25k lines header for this idiotic problem, it's silly.

I swear most weird graphics problems we stumble upon here are NVIDIA's fault.

Edit: obv I misread your comment and you already commented it as a possibility, sorry. Obviously try doing this if it's humanly feasible, knowing nvidia I wouldn't be surprised if it were a jumbled mess.

EIREXE · 2023-01-17T17:32:38Z

@EIREXE would it be possible (aka without too much trouble) to trim everything that isn't the threaded optimization part from the thirdparty code or is it too jumbled up for that?

I can't imagine that most big graphics programs just import this huge gigantic 25k lines header for this idiotic problem, it's silly.

I swear most weird graphics problems we stumble upon here are NVIDIA's fault.

Edit: obv I misread your comment and you already commented it as a possibility, sorry. Obviously try doing this if it's humanly feasible, knowing nvidia I wouldn't be surprised if it were a jumbled mess.

I've done just that, seems to work fine.

clayjohn · 2023-01-17T17:50:55Z

@EIREXE I guess you can remove the original NVAPI file right?

EIREXE · 2023-01-17T18:36:56Z

@EIREXE I guess you can remove the original NVAPI file right?

oh my b, I forgot to remove it

doc/classes/ProjectSettings.xml

platform/windows/gl_manager_windows.cpp

thirdparty/README.md

thirdparty/nvapi/nvapi_minimal.h

EIREXE · 2023-06-13T09:44:42Z

Sorry for the many mess-ups, should be fine now I hope.

akien-mga

Looks great!

akien-mga · 2023-06-13T11:56:30Z

Thanks!

Calinou · 2023-09-02T21:12:42Z

For context, this is not necessary on Linux as threaded optimizations are disabled by default there.

An NVIDIA profile is applied to the current executable to disable threaded OpenGL optimizations on Windows (see godotengine#71472). But because the application is only added to the profile upon the profile creation, newer executables won't be added to the profile (e.g. if the profile is created on first launch of Godot_v4.1-stable_win64.exe, when users update the editor and launch Godot_v4.2-stable_win64.exe, the profile will never be applied to this new executable). This patch fixes that scenario by splitting creating the profile (if it doesn't exist) and adding the application (if it doesn't have a profile applied) into two separate steps. Applications that have been manually added to a different profile aren't overriden to avoid confusing users who know what they're doing.

An NVIDIA profile is applied to the current executable to disable threaded OpenGL optimizations on Windows (see godotengine#71472). But because the application is only added to the profile upon the profile creation, newer executables won't be added to the profile (e.g. if the profile is created on first launch of Godot_v4.1-stable_win64.exe, when users update the editor and launch Godot_v4.2-stable_win64.exe, the profile will never be applied to this new executable). This patch fixes that scenario by splitting creating the profile (if it doesn't exist) and adding the application (if it doesn't have a profile applied) into two separate steps. Applications that have been manually added to a different profile aren't overriden to avoid confusing users who know what they're doing. (cherry picked from commit 6263774)

jsjtxietian · 2023-11-14T11:40:23Z

platform/windows/gl_manager_windows.cpp

+}
+
+// On windows we have to disable threaded optimization when using NVIDIA graphics cards
+// to avoid stuttering, see https://github.com/microsoft/vscode-cpptools/issues/6592


The link to vscode's issue seems irrelevant, am I understand it wrong?

I am stupid indeed, the correct link should be https://stackoverflow.com/questions/36959508/nvidia-graphics-driver-causing-noticeable-frame-stuttering/37632948

Thanks ! I will take a look, Can I help you make a pr correct this ?

I'm very busy lately, so I would be very thankful if you could do it for me

jsjtxietian · 2023-11-19T05:12:15Z

platform/windows/gl_manager_windows.cpp

+	setting.isCurrentPredefined = 0;
+	setting.isPredefinedValid = 0;
+	int thread_control_val = OGL_THREAD_CONTROL_DISABLE;
+	if (!GLOBAL_GET("rendering/gl_compatibility/nvidia_disable_threaded_optimization")) {


Can we check nvidia_disable_threaded_optimization at the beginning of the function to avoid crash in #84880 ?

EIREXE requested review from a team as code owners January 15, 2023 18:13

EIREXE force-pushed the nvapi-threaded-optimization branch from e3ddbe3 to 711b0ce Compare January 15, 2023 18:22

bruvzg reviewed Jan 15, 2023

View reviewed changes

Calinou added bug platform:windows topic:core topic:rendering performance labels Jan 15, 2023

Calinou added this to the 4.0 milestone Jan 15, 2023

EIREXE force-pushed the nvapi-threaded-optimization branch from 711b0ce to 8bc071e Compare January 15, 2023 19:00

EIREXE force-pushed the nvapi-threaded-optimization branch from 8bc071e to 7dd4110 Compare January 15, 2023 19:03

EIREXE force-pushed the nvapi-threaded-optimization branch from 7dd4110 to 2d4270b Compare January 17, 2023 17:12

EIREXE force-pushed the nvapi-threaded-optimization branch from 2d4270b to c1fabd4 Compare January 17, 2023 18:37

clayjohn modified the milestones: 4.0, 4.x Jan 19, 2023

Calinou reviewed Apr 18, 2023

View reviewed changes

doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved

Calinou approved these changes Apr 18, 2023

View reviewed changes

EIREXE force-pushed the nvapi-threaded-optimization branch 2 times, most recently from 0dad4ec to 947e562 Compare April 18, 2023 23:31

akien-mga reviewed Jun 13, 2023

View reviewed changes

platform/windows/gl_manager_windows.cpp Outdated Show resolved Hide resolved

akien-mga reviewed Jun 13, 2023

View reviewed changes

thirdparty/README.md Outdated Show resolved Hide resolved

akien-mga reviewed Jun 13, 2023

View reviewed changes

thirdparty/nvapi/nvapi_minimal.h Outdated Show resolved Hide resolved

akien-mga modified the milestones: 4.x, 4.1 Jun 13, 2023

EIREXE force-pushed the nvapi-threaded-optimization branch from 0c72d3a to 3fba270 Compare June 13, 2023 09:44

EIREXE force-pushed the nvapi-threaded-optimization branch from 3fba270 to 938a837 Compare June 13, 2023 09:47

Disable NVIDIA's threaded optimization on Windows

938a837

akien-mga approved these changes Jun 13, 2023

View reviewed changes

akien-mga merged commit 5288a69 into godotengine:master Jun 13, 2023

akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 13, 2023

akien-mga changed the title ~~Disable NVIDIA's threaded optimization on Windows~~ Disable NVIDIA's threaded OpenGL optimization on Windows Jul 5, 2023

aitorciki mentioned this pull request Sep 2, 2023

[Windows] Fix not applying NVIDIA profile to new executables #81251

Merged

Calinou mentioned this pull request Nov 5, 2023

Provide convenience method for disabling nvidia 'threaded optimizations' feature xemu-project/xemu#1320

Open

jsjtxietian mentioned this pull request Nov 14, 2023

Can't use renderdoc to launch compatibility godot project #84880

Closed

jsjtxietian reviewed Nov 14, 2023

View reviewed changes

jsjtxietian mentioned this pull request Nov 17, 2023

Fix wrong reference link in _nvapi_disable_threaded_optimization #85012

Closed

jsjtxietian reviewed Nov 19, 2023

View reviewed changes

Calinou mentioned this pull request Nov 20, 2023

NVIDIA Instant Replay status indicator is everywhere now #85111

Open

mhilbrunner mentioned this pull request May 7, 2024

[Windows] Fix NVIDIA app profile creation #85188

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable NVIDIA's threaded OpenGL optimization on Windows #71472

Disable NVIDIA's threaded OpenGL optimization on Windows #71472

EIREXE commented Jan 15, 2023 •

edited by Calinou

Loading

EIREXE commented Jan 15, 2023

clayjohn commented Jan 16, 2023

aaronfranke commented Jan 16, 2023

EIREXE commented Jan 16, 2023

Riteo commented Jan 17, 2023 •

edited

Loading

EIREXE commented Jan 17, 2023

clayjohn commented Jan 17, 2023

EIREXE commented Jan 17, 2023

EIREXE commented Jun 13, 2023

akien-mga left a comment

akien-mga commented Jun 13, 2023

Calinou commented Sep 2, 2023 •

edited

Loading

jsjtxietian Nov 14, 2023

EIREXE Nov 14, 2023

jsjtxietian Nov 15, 2023 •

edited

Loading

EIREXE Nov 16, 2023

jsjtxietian Nov 19, 2023

Disable NVIDIA's threaded OpenGL optimization on Windows #71472

Disable NVIDIA's threaded OpenGL optimization on Windows #71472

Conversation

EIREXE commented Jan 15, 2023 • edited by Calinou Loading

EIREXE commented Jan 15, 2023

clayjohn commented Jan 16, 2023

aaronfranke commented Jan 16, 2023

EIREXE commented Jan 16, 2023

Riteo commented Jan 17, 2023 • edited Loading

EIREXE commented Jan 17, 2023

clayjohn commented Jan 17, 2023

EIREXE commented Jan 17, 2023

EIREXE commented Jun 13, 2023

akien-mga left a comment

Choose a reason for hiding this comment

akien-mga commented Jun 13, 2023

Calinou commented Sep 2, 2023 • edited Loading

jsjtxietian Nov 14, 2023

Choose a reason for hiding this comment

EIREXE Nov 14, 2023

Choose a reason for hiding this comment

jsjtxietian Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

EIREXE Nov 16, 2023

Choose a reason for hiding this comment

jsjtxietian Nov 19, 2023

Choose a reason for hiding this comment

EIREXE commented Jan 15, 2023 •

edited by Calinou

Loading

Riteo commented Jan 17, 2023 •

edited

Loading

Calinou commented Sep 2, 2023 •

edited

Loading

jsjtxietian Nov 15, 2023 •

edited

Loading