Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RichTextLabel wrong selection offset in padded table cell. #71742

Merged

Conversation

Koyper
Copy link
Contributor

@Koyper Koyper commented Jan 20, 2023

This corrects an issue in RichTextLabel where a selection inside a table cell with padding, incorrectly offset the start of the selection by the width of the padding.

You can observe this behavior in any of the docs that have a code block in the description, such as PackedStringArray.

Bugsquad edit: Fixes #64292

@Koyper Koyper requested a review from a team as a code owner January 20, 2023 16:03
@akien-mga akien-mga requested a review from bruvzg January 20, 2023 16:09
@akien-mga akien-mga added this to the 4.0 milestone Jan 20, 2023
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 17, 2023
@YuriSizov YuriSizov merged commit 6a65597 into godotengine:master Apr 11, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@Koyper Koyper deleted the rich_text_label_cell_padding_select_bug branch April 11, 2023 13:20
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

@akien-mga akien-mga changed the title Fixed RichTextLabel wrong selection offset in padded table cell. Fix RichTextLabel wrong selection offset in padded table cell. May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection in Editor Help is not accurate
4 participants