Ensure that Particles have fully initialized before doing view axis pass in RD renderers #71925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass in RD renderers
akien-mga
approved these changes
Jan 23, 2023
|
Thanks! |
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first reported issue in #70607 but not the second
trail_bind_pose_uniform_setis initialized when the particles are processed for the first time. This code runs each frame and is used when the particles require camera-based effects or custom sorting. So it is possible for this to be called without the particles having been processed. So we need a more comprehensive early out.This change isn't needed in the GL_Compatibility renderer as it doesn't have support for trails.