Enforce Signal parameter types in Connect #71952
Draft
+297
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning work for Typed signals.
Adds
get_method_info()
to Callable (not exposed to Godot) for retrieving Callable arg info.Object's
connect
method now checks if the correct amount of non-initialized arguments exist in the callable, and if the types are equal (todo: Check if types are compatible instead). Currently only implemented inconnect
Task list:
Check if types are compatible instead of doing explicit ==
Add checks in the analyzer to error ahead of time when
connect
uses a non-compatible CallableRewrite messages for readability
Clean-up code
Write tests
Example
Bugsquad edit: This closes godotengine/godot-proposals#2557 and closes #54333.