Massive improvemnts to shadows quality/flexibility

[jay3d]

Significant changes to how PCF shadows work, made them took less samples with higher quality results, also added more flexible control of the filtering radius in the editor.

[reduz]

Nice, will review soon, as this will have to be merged to the gles3 branch

…

On Nov 29, 2016 12:23 PM, "Jamil Halabi" ***@***.***> wrote: Significant changes to how PCF shadows work, made them took less samples with higher quality results, also added more flexible control of the filtering radius in the editor. ------------------------------ You can view, comment on, or merge this pull request online at: #7204 Commit Summary - Massive improvemnts to shadows quality/flexibility File Changes - *M* drivers/gles2/rasterizer_gles2.cpp <https://github.com/godotengine/godot/pull/7204/files#diff-0> (14) - *M* drivers/gles2/rasterizer_gles2.h <https://github.com/godotengine/godot/pull/7204/files#diff-1> (1) - *M* drivers/gles2/shaders/canvas.glsl <https://github.com/godotengine/godot/pull/7204/files#diff-2> (86) - *M* drivers/gles2/shaders/material.glsl <https://github.com/godotengine/godot/pull/7204/files#diff-3> (93) - *M* scene/2d/light_2d.cpp <https://github.com/godotengine/godot/pull/7204/files#diff-4> (16) - *M* scene/2d/light_2d.h <https://github.com/godotengine/godot/pull/7204/files#diff-5> (4) - *M* scene/3d/light.cpp <https://github.com/godotengine/godot/pull/7204/files#diff-6> (4) - *M* scene/3d/light.h <https://github.com/godotengine/godot/pull/7204/files#diff-7> (1) - *M* servers/visual/rasterizer.h <https://github.com/godotengine/godot/pull/7204/files#diff-8> (8) - *M* servers/visual/visual_server_raster.cpp <https://github.com/godotengine/godot/pull/7204/files#diff-9> (8) - *M* servers/visual/visual_server_raster.h <https://github.com/godotengine/godot/pull/7204/files#diff-10> (1) - *M* servers/visual/visual_server_wrap_mt.h <https://github.com/godotengine/godot/pull/7204/files#diff-11> (1) - *M* servers/visual_server.h <https://github.com/godotengine/godot/pull/7204/files#diff-12> (2) Patch Links: - https://github.com/godotengine/godot/pull/7204.patch - https://github.com/godotengine/godot/pull/7204.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7204>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z2-LihhQZ6JNsnB-tkMJWE2XOvqn-ks5rDENZgaJpZM4K_GNW> .

[ScotFlux]

Spectacular. You've just got Godot 🏆 Congratulations! 👍

[khairul169]

Nice catch! :D

[akien-mga]

@jay3d Would you mind redoing this PR against the 2.1 branch? We'd gladly merge it to include this in the future 2.1.3-stable release.

For master/3.0, it would have to be implemented differently, but @reduz would likely use this PR as a reference.

[Zireael07]

This would be awesome to see, poke @jay3d

[akien-mga]

Bump :) I would still consider merging this in the 2.1 branch if rebased and/or having a new PR for the master branch, if relevant with the gles3 rasterizer.

[akien-mga]

Closing as it can't be merged in master at any rate, but if someone wants to try to port this to the 2.1 branch, it would be quite interesting.

[Calinou]

I had a try at porting this to the master branch with GLES3, but unfortunately, there's a noticeable dithering pattern:

I could confirm this by compiling and running the branch from this pull request (based on Godot 2.1):

Both screenshots were taken with the "High" shadow filter quality; the shadow filter radius was set to 1.5.