Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AudioStreamGenerator stopping playback after a buffer underrun #73162

Closed
wants to merge 1 commit into from
Closed

Fix AudioStreamGenerator stopping playback after a buffer underrun #73162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion servers/audio_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ void AudioServer::_mix_step() {
playback->stream_playback->tag_used_streams();
}

if (mixed_frames != buffer_size) {
if (!playback->stream_playback->is_playing()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is the wrong solution, and it should be fixed on the side of the generator code.

// We know we have at least the size of our lookahead buffer for fade-out purposes.

float fadeout_base = 0.94;
Expand Down