Fix guide button detection with XInput and Xbox Series controllers #73200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets Godot detect the guide button when running on windows and using the XInput API.
Changes the call of the XInputGetState function with some undocumented function that returns the same thing, but with an extra bit that corresponds to the guide button state.
see https://github.com/higan-emu/higan/blob/master/ruby/input/joypad/xinput.cpp as an example for another place where they use the undocumented feature
I think this feels kinda hacky, so let me know if I should fix it with better naming, some documentation comments or maybe put it behind a compile flag.
The PR also adds the guide button to the controller db for the Xbox Series gamepad (maybe works with others, didn't test)