C#: Fix internal source generator on the 7.0.200 SDK #73382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
requested changes
Feb 15, 2023
modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/UnmanagedCallbacksGenerator.cs
Outdated
Show resolved
Hide resolved
RedworkDE
force-pushed
the
net-source-gen-param
branch
from
1658969
to
fce8a05
Compare
neikeq
approved these changes
Feb 16, 2023
raulsntos
approved these changes
Feb 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: After installing the 7.0.200 SDK, GodotSharp fails to compile with a whole bunch of errors like:
dotnet/roslyn#65606 which is included in the 7.0.200 SDK changed
IParameterSymbol.ToDisplayString()to include the parameter name, after which we add a second parameter name, and the generator output fails to compile.This PR uses the corresponding
ParameterSyntax(which actually corresponds to source code and is not just intended for display to the user) instead.WithAttributeLists(default)is used to skip custom attributes int the generated output, which would duplicate them and possibly break (if we were to actually use any with the callbacks).Future work: Audit all uses of
ToDisplayStringand replace them, as they appear to not be intended for generating source.