Disable AMD switchable graphics on Windows with Vulkan to fix driver issue

[Calinou]

This is a required workaround on setups with AMD integrated graphics + NVIDIA dedicated GPU to be able to start the engine with the Forward+ or Forward Mobile rendering methods.

While a AMD driver update can resolve this issue, it still gets reported regularly and is likely to become a source of support headache for people distributing projects made with Godot (as this also affects exported projects).

The only case where disabling integrated graphics is really a problem is for non-game applications, but these are likely to use OpenGL anyway due to the lower rendering base cost and system requirements.

Please test, as I have no setup to test this locally. This targets a merge for 4.1 with a backport to 4.0.x.

• This closes Vulkan: Can't start Godot with AMD integrated + NVIDIA dedicated GPU switchable graphics (Failed dispatch call vkEnumeratePhysicalDevices) #57708.

Windows 64-bit editor binary for testing this PR: https://0x0.st/HrFk.exe.zip _{(link expires in late 2023)}

Older build

Windows 64-bit editor binary for testing this PR: https://0x0.st/HrGR.exe.zip _{(link expires in late 2023)}

[lmurray]

This could probably be moved into the Windows Vulkan context itself so it doesn't affect other drivers such as D3D12.

[Calinou]

This could probably be moved into the Windows Vulkan context itself so it doesn't affect other drivers such as D3D12.

I've pushed a second commit with an updated Windows build in OP for testing.

[RobertBeckebans]

Nvidia's NVRHI / donut checks with the Vulkan API for dedicated GPUs as an alternative to set a environment variable:
if (prop.deviceType == vk::PhysicalDeviceType::eDiscreteGpu)

See https://github.com/NVIDIAGameWorks/donut/blob/7ecdf8899fee34a8138417a6b00239bcb308716d/src/app/vulkan/DeviceManager_VK.cpp#L559

[Wuyou55]

AMD R7 + 2060(note books) This PR can be used.
thx.

[livolickie]

Working on R7 3750H (RX Vega 10) + GTX 1650 Mobile (Laptop)

[Calinou]

Nvidia's NVRHI / donut checks with the Vulkan API for dedicated GPUs as an alternative to set a environment variable:
if (prop.deviceType == vk::PhysicalDeviceType::eDiscreteGpu)

See NVIDIAGameWorks/donut@7ecdf88/src/app/vulkan/DeviceManager_VK.cpp#L559

This is interesting, but we only need to disable AMD switchable graphics, as Intel switchable graphics seem to work just fine.

[MonT97]

Working in a ryzen7 4800H with an integrated and a GTX 1650 (driver v522.25) laptop

graphic adapter windows graphic settings is not set (the program isn't added)

[clayjohn]

I don't love having to include a hack like this. But it seems well tested and appropriately limited to the windows platform, so lets go ahead and merge

[akien-mga]

Doesn't this mean that we'd never use AMD discrete GPUs when available?

[clayjohn]

Doesn't this mean that we'd never use AMD discrete GPUs when available?

I think it means we would never use the AMD integrated GPU when a dedicated GPU is available

Nevermind setting DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 just ensures that the driver exposes the two GPUs as two different GPUs instead of exposing them as a single GPU

[akien-mga]

Thanks!

[YuriSizov]

Cherry-picked for 4.0.4.

[MarouanDoulahiane]

ERROR: vkCreateComputePipelines failed with error -1000012000.
at: (drivers/vulkan/rendering_device_vulkan.cpp:6522)