Fix custom resource icons not showing up in FileSystem #73611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atlinx
force-pushed
the
fix/32706_custom-resource-icons-new
branch
2 times, most recently
from
30ede28
to
c6f6533
Compare
Atlinx
changed the title
Atlinx
force-pushed
the
fix/32706_custom-resource-icons-new
branch
from
c6f6533
to
3001d44
Compare
Edited EditorResourcePreview to cache icons when generating previews for resources.
Atlinx
force-pushed
the
fix/32706_custom-resource-icons-new
branch
from
3001d44
to
7e89fc1
Compare
Well, it changes the signature of a callback method, so it cannot be backported. And we need to be careful about it in 4.x too. |
|
Superseded by #77932. Thanks for the contribution nevertheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32706.
Makes custom resource icons show up in FileSystem. This is implemented by having the editor resource preview generator also store icon information when a preview is generated. Since
filesystem_dock.cppalready useseditor_resource_preview.h, only minor changes were needed to integrate this.Can probably be backported to 3.x.EDIT: Changes method signature so compat breaks