Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] BVH - fix lockguards for multithread mode #73629

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

lawnjelly
Copy link
Member

Due to a lack of variable name, the BVH lock guards lifetimes previously did not cover the whole function call.

Notes

  • Version of BVH - fix lockguards for multithread mode #73628 for 3.x.
  • Does not remove the contention message, as multithread mode is not designed for production use in 3.x. Does change it to a WARN_PRINT_ONCE as that is probably a better option.

Due to a lack of variable name, the BVH lock guards lifetimes previously did not cover the whole function call.
@lawnjelly lawnjelly requested a review from a team as a code owner February 20, 2023 15:44
@lawnjelly lawnjelly added this to the 3.6 milestone Feb 20, 2023
@lawnjelly lawnjelly added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Feb 20, 2023
@akien-mga akien-mga changed the title BVH - fix lockguards for multithread mode [3.x] BVH - fix lockguards for multithread mode Feb 20, 2023
@lawnjelly lawnjelly merged commit ca823e1 into godotengine:3.x Feb 20, 2023
@lawnjelly lawnjelly deleted the bvh_mutex_fix_3 branch February 20, 2023 17:26
@akien-mga
Copy link
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants