Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to reference a class constructor as a Callable #73657

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Allow to reference a class constructor as a Callable #73657

merged 1 commit into from
Jun 18, 2023

Conversation

mashumafi
Copy link
Contributor

@mashumafi mashumafi commented Feb 21, 2023 •
edited
Loading

Fixes #70319

Now constructors of Scripts and Native objects can be retrieved as a Callable.

@mashumafi mashumafi requested a review from a team as a code owner February 21, 2023 02:57
@akien-mga akien-mga added this to the 4.1 milestone Feb 21, 2023
adamscott
adamscott approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! Thanks!

@akien-mga akien-mga merged commit 4db1d09 into godotengine:master Jun 18, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov changed the title Fix: Get constructor as Callable Allow to reference a class constructor as a Callable Jun 21, 2023
@mashumafi mashumafi deleted the callable-ctor branch July 11, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Cannot get constructor of inner class
3 participants
@mashumafi @akien-mga @adamscott