Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Filter Files shortcut input is not properly handled #73981

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix Filter Files shortcut input is not properly handled #73981

merged 1 commit into from
Oct 30, 2023

Conversation

stmSi
Copy link
Contributor

@stmSi stmSi commented Feb 26, 2023

Fix #73978

@akien-mga akien-mga added this to the 4.1 milestone Feb 26, 2023
@akien-mga akien-mga modified the milestones: 4.1, 4.2 Jun 19, 2023
YuriSizov
YuriSizov approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see from the discussion on the issue that this is not always reproduceable (and might be system-dependent), but I don't see harm in this change.

WDYT @KoBeWi ?

@AThousandShips AThousandShips changed the title Fix Filter Files shortcut input is not properly handling Fix Filter Files shortcut input is not properly handled Oct 30, 2023
KoBeWi
KoBeWi approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's rather harmless.
Another option could be using deferred call for focus_on_filter().

@akien-mga akien-mga merged commit a7c81f4 into godotengine:master Oct 30, 2023
@akien-mga
Copy link
Member

Thanks!

@stmSi stmSi deleted the fix-filter-files-shortcut-input-not-handling branch October 30, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

@EricEzaM EricEzaM Awaiting requested review from EricEzaM

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Shortcut key Ctrl+Alt+p is inserting 'p' into the "Filter Files" Searchbox
4 participants
@stmSi @akien-mga @KoBeWi @YuriSizov