Add get_loops_left() function to Tween #74454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pennycook
force-pushed
the
get_loops_left
branch
from
1ce9502
to
23dfde7
Compare
Pennycook
force-pushed
the
get_loops_left
branch
from
23dfde7
to
79a6d4f
Compare
Pennycook
force-pushed
the
get_loops_left
branch
from
79a6d4f
to
d1c617d
Compare
|
Rebased and force-pushed to restart the checks. They all failed last time, but the failures seemed unrelated to my changes. |
|
Tests are passing now, @KoBeWi. |
KoBeWi
reviewed
Mar 20, 2023
KoBeWi
reviewed
Mar 20, 2023
Pennycook
force-pushed
the
get_loops_left
branch
from
63b8151
to
d30dc65
Compare
Implements godotengine/godot-proposals#5141. Adds a new get_loops_left() function to Tween, allowing developers to reason about how many times a tweening sequence will repeat and whether to expect finished or loop_finished as the next signal. Co-authored-by: Tomek <[email protected]>
Pennycook
force-pushed
the
get_loops_left
branch
from
d30dc65
to
4cb2085
Compare
|
@KoBeWi Squashed and pushed. Is there anything else that needs to happen before this can be merged? I'm asking to understand the workflow (and make sure I didn't miss a step), not to try and rush this along. |
|
No, it's ready to merge now. |
|
Indeed, it is. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements godotengine/godot-proposals#5141.
Adds a new
get_loops_left()function toTween, allowing developers to reason about how many times a tweening sequence will repeat and whether to expectfinishedorloop_finishedas the next signal.