-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion for common Theme Overrides #74624
Add conversion for common Theme Overrides #74624
Conversation
Can't we just rename the sections instead of listing some specific and arbitrary properties? |
Unfortunately not in all cases. And using e.g. |
What I mean is, can't we rename |
Ahh. Yeah, that should be possible. Then the theme conversion needs two steps:
I can check that out tomorrow. :) |
855ea3a
to
da406a9
Compare
Done. I still opted for the safer approach, so we really won't be converting any unrelated properties/variables. |
da406a9
to
a40f559
Compare
Thanks! |
Cherry-picked for 4.0.1. |
Fixes: #66052
This PR adds conversion for the most commonly used theme overrides.
This includes:
-> Margins, StyleBoxes etc. will still work after the migration.