Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix missing warning for shadowing of built-in types #74842

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Mar 12, 2023

func _ready():
  var Array := 3 # before: ok, after: warning

Extracted from #74618.

@vonagam vonagam requested a review from a team as a code owner March 12, 2023 22:53
@YeldhamDev YeldhamDev added this to the 4.x milestone Mar 13, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 Mar 20, 2023
@YuriSizov YuriSizov merged commit a5f3474 into godotengine:master Mar 20, 2023
@YuriSizov
Copy link
Contributor

Thanks!

PS. Now that it returns nothing, the name of GDScriptAnalyzer::is_shadowing is not great. It should probably be something like check_if_shadowing or test_shadowing, or some version of these.

@vonagam vonagam deleted the fix-builtin-shadow branch March 20, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants