Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert attempted fix of trimesh CCD #74861

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

rburing
Copy link
Member

@rburing rburing commented Mar 13, 2023

This reverts a part of #72917 which was not the correct solution to the problem.

The issue #72889 remains fixed.

Adding gravity_scale = 5.0 to the MRP from #72889 still shows a tunneling issue, hence the FIXME comment.

@fabriceci
Copy link
Contributor

I'm looking at it tomorrow. Can you add tests to the test project, to reduce the risk of regressions?

@Chaosus Chaosus added this to the 4.1 milestone Mar 14, 2023
@rburing
Copy link
Member Author

rburing commented Mar 16, 2023

@fabriceci I've added a test here:

Regression test output with this PR:

trimesh-ccd-test

This PR reverts an incorrect attempt to fix rigid body CCD against trimesh static bodies. That previous attempt did prevent tunneling (hence reverting it causes a regression), but it had the side effect of no longer detecting collisions, which is worse, since that issue can affect many projects, see #74756 (comment).

The test project uses the extreme speed 25000. As mentioned above, the regression does not happen for all bodies/speeds, e.g. #72889 remains fixed. In the test project the threshold is at speed 550.

Copy link
Contributor

@fabriceci fabriceci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriSizov YuriSizov merged commit a7d0e18 into godotengine:master Mar 17, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@rburing rburing deleted the restore_trimesh_ccd branch March 17, 2023 10:04
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roughly Perpendicular Collisions with Concave Polygon are not detected and stick
4 participants