-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow creating a project in the Home or Documents folder #74964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't prompt users to delete the project folder for now. This is a temporary fix to ensure that users do not delete their entire home folders by mistake
clayjohn
force-pushed
the
pm-file-safety
branch
from
March 15, 2023 23:39
4ba389d
to
45a26ff
Compare
akien-mga
approved these changes
Mar 16, 2023
Thanks! |
PS: While this is labeled |
Cherry-picked for 4.0.1. |
Will the option to delete project content come back in the future? |
As the PR says it's temporary and while working on a way to do it safely, see also #56420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #74678.
This PR does 2 things:
Project creation menu by default
Project creation menu when another non-empty path is chosen