Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bindings and documentation for MultiplayerPeerExtension #75116

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Add missing bindings and documentation for MultiplayerPeerExtension #75116

merged 1 commit into from
Mar 20, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Mar 19, 2023 •
edited
Loading

Fixes #74628

@dsnopek dsnopek added this to the 4.x milestone Mar 19, 2023
@dsnopek dsnopek requested a review from a team March 19, 2023 20:19
@dsnopek dsnopek requested review from a team as code owners March 19, 2023 20:19
@dsnopek dsnopek mentioned this pull request Mar 19, 2023
Closed
@dsnopek dsnopek added the bug label Mar 19, 2023
@dsnopek dsnopek force-pushed the multiplayer-peer-extension-missing-docs branch 2 times, most recently from 510f4ed to 94ea73e Compare March 20, 2023 02:25
@dsnopek dsnopek changed the title Add documentation for MultiplayerPeerExtension._get_packet_channel() … Add missing documentation for MultiplayerPeerExtension Mar 20, 2023
YuriSizov
YuriSizov approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nitpick though.

@dsnopek dsnopek force-pushed the multiplayer-peer-extension-missing-docs branch from 94ea73e to 4d13be3 Compare March 20, 2023 15:10
@YuriSizov YuriSizov merged commit b1c18f8 into godotengine:master Mar 20, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 Mar 20, 2023
@akien-mga akien-mga mentioned this pull request May 11, 2023
Closed
@akien-mga
Copy link
Member

Cherry-picked for 4.0.3.

@akien-mga akien-mga changed the title Add missing documentation for MultiplayerPeerExtension Add missing bindings and documentation for MultiplayerPeerExtension May 12, 2023
@dsnopek dsnopek deleted the multiplayer-peer-extension-missing-docs branch July 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug documentation topic:gdextension topic:network
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

MultiplayerPeerExtension requires more overrides than docs specify
4 participants
@dsnopek @YuriSizov @akien-mga @Faless