Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port robust signal (dis)connection to ShapeCast2D #75266

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Port robust signal (dis)connection to ShapeCast2D #75266

merged 1 commit into from
Mar 27, 2023

Conversation

rburing
Copy link
Member

@rburing rburing commented Mar 23, 2023 •
edited
Loading

Ported from ShapeCast3D. Fixes #75233.

@rburing rburing requested a review from a team as a code owner March 23, 2023 18:17
@KoBeWi KoBeWi added this to the 4.1 milestone Mar 23, 2023
bruvzg
bruvzg reviewed Mar 24, 2023
View reviewed changes
scene/2d/shape_cast_2d.cpp Outdated Show resolved Hide resolved
scene/2d/shape_cast_2d.cpp Outdated Show resolved Hide resolved
@rburing rburing requested a review from a team as a code owner March 24, 2023 08:24
@YuriSizov YuriSizov merged commit 2659fc1 into godotengine:master Mar 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.1
4 participants
@rburing @YuriSizov @bruvzg @KoBeWi