-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gles texture uniform array binding #75313
Fix gles texture uniform array binding #75313
Conversation
Thanks for opening a pull request! Please squash your commits into a single one. Make sure that the commit message stays short but descriptive (your original message and the title of this PR are a good option). And to your knowledge, does this address any open issue? |
48eaeef
to
e2bad9e
Compare
@YuriSizov thanks, I squashed the commits. Should I open an issue describing the bugs fixed here? |
No, it's not necessary at this point. I was mostly curious if this would reduce our backlog of existing issues :) |
47d4778
to
4eacfcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I just have one little requested change because we try to avoid using auto
unless absolutely necessary.
4fcf9da
to
719af76
Compare
This looks good to go, it just needs to be rebased to resolve conflicts |
563c29f
to
27da9ad
Compare
27da9ad
to
6d3634e
Compare
Thanks! |
Fix both texture uniform binding and texture object binding in gles (compatibility ) mode for godot 4
Before this change, the engine (editor / game) crashes whenever there is an array of sampler2D in compatibility mode
The following line in any shader crashes:
uniform sampler2D[10] textures;
Production edit: Fixes #76463