Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and inconsistencies in classref #75389

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

timothyqiu
Copy link
Member

  • Typo fixes.
  • Navigation agent's velocity_computed signal is not emitted by set_velocity, but at the end of that frame if set_velocity is called.
  • Simplify link in navigation agent's avoidance_enabled description.
  • Unify navigation_layers description across NavigationAgent{2,3}D.
  • Unify is_normalized() description across Vector2, Vector3, and Vector4

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning that the length is approximately equal to 1, but perhaps that's too pedantic.

* Typo fixes.
* Navigation agent's `velocity_computed` signal is not emitted by
  `set_velocity`, but at the end of that frame if `set_velocity` is
  called.
* Simplify link in navigation agent's `avoidance_enabled` description.
* Unify `navigation_layers` description across `NavigationAgent{2,3}D`.
* Unify `is_normalized()` description across `Vector2`, `Vector3`, and
  `Vector4`
@YuriSizov YuriSizov merged commit 2a275b9 into godotengine:master Mar 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the typo-fixes branch March 27, 2023 15:02
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants