Fix the sliding down of the window due to the reparenting caused by the window manager decorations. #75709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he window manager decorations
n0tank3sh
force-pushed
the
fix-sliding-window-linux
branch
from
5850527
to
7fc658c
Compare
bruvzg
reviewed
Apr 12, 2023
| DEBUG_LOG_X11("show_window: %lu (%u) \n", wd.x11_window, p_id); | ||
|
|
||
| XMapWindow(x11_display, wd.x11_window); | ||
| XSync(x11_display, False); | ||
| _validate_mode_on_map(p_id); | ||
| if (!wd.borderless && !wd.fullscreen && !wd.exclusive_fullscreen) { | ||
| usleep(50000); // waiting for the window-manager to compelete the decoration of the window |
There was a problem hiding this comment.
There has to be a better solution, I got the idea (and it should work in most cases), but relying on delay is not a robust thing.
There was a problem hiding this comment.
Well, we can track the window's parent through notify configure sent by the window manager while decorating. I don't know if that will be optimal.
|
Superseded by #76040. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the sliding down of the window due to the reparenting by the window manager which is done after mapping the window in X11.
fixes #75292 and many more. It also slows down the thread as it waits for the window manager to complete the decorations. It would be optimal to start a new thread that will execute this solution and then terminate itself. I would love to have the dev's opinion on this.
Edit: It also doesn't work if the window manager takes more time in decoration than the waiting time given which can be solved by increasing the waiting time but it also slows the program even more.
Edit: It also just slows down the tiling window manager as XMoveWindow does not affect them.
Edit: Another solution as discussed in the review with no delay #76040