Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure script cache is created after reimport #75798

Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 7, 2023

Fixes #75684

For whatever reason there are 2 reimport paths. The other one is here:

scanning = false;
_update_pending_script_classes();
emit_signal(SNAME("filesystem_changed"));
emit_signal(SNAME("sources_changed"), sources_changed.size() > 0);
first_scan = false;

and it was executed too late. I did not try understand this logic...

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to review all the implications so TIWAGOS, but I think we can give it a spin as it fixes an important bug and seems relatively risk free.

@akien-mga akien-mga merged commit 9be0aab into godotengine:master Jun 12, 2023
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the let's_fix_this_hack_with_yet_another_hack branch June 12, 2023 21:28
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants