Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connect signal dialog not allowing Unicode method name #75814

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

timothyqiu
Copy link
Member

Unicode identifiers are supported now, but currently in "Connect Signal to Method" dialog:

  • Unicode characters will be removed for the default generated method name (introduced by node name or signal name).
  • You'll get a "Method name must be a valid identifier" error if the method name you specified contains Unicode characters.

When generating the default method name, this PR only removes characters that does not satisfy the ID_Start / ID_Continue requirement. Possible Unicode security checks are performed when submitting the dialog.

CC @bruvzg

@YuriSizov YuriSizov merged commit 220953b into godotengine:master Apr 10, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants