Fix Linux fullscreen mode doesn't preserve maximized state #75838
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
akien-mga
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Won't this fail if you have multiple windows?
In the Windows platform there is also a was_maximized boolean but it's part of the WindowData, so it's window-specific. Here it's a single boolean for the whole DisplayServer so maximizing or windowing any window will impact the value, causing unexpected behavior.
Also I assume the macOS DisplayServer needs the same treatment?
akien-mga
added
cherrypick:4.1
YuriSizov
removed
the
cherrypick:4.1
|
I guess this is related to (and the opposite of) #84504? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #75804
Unlike what happens under Windows, the maximized state was not saved when switching to full screen.
Added a
was_maximizedvariable to restore previous windowed state while leaving fullscreen.