Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exported variables declaring or inferring the type were not converted correctly #75900

Conversation

Maran23
Copy link
Contributor

@Maran23 Maran23 commented Apr 10, 2023

Fixes: #75852

Fixed the following two problems which may occur when converting exported variables:

  • When an exported variable declared a type like the following:
    export(int) var integer: int = 2
    it was incorrectly converted to:
    @export var integer: int: int = 2
  • When an exported variable inferred the type like the following:
    export(int) var integer := 2
    it was incorrectly converted to:
    @export var integer: int := 2

Added also a bunch of conversion tests.

@YuriSizov YuriSizov added this to the 4.1 milestone Apr 10, 2023
@Maran23 Maran23 force-pushed the project-converter-declaring-inferring-types branch from 0f083e5 to 55ba34a Compare June 12, 2023 17:20
@akien-mga akien-mga merged commit efea8ae into godotengine:master Jun 12, 2023
@akien-mga
Copy link
Member

Thanks!

@Maran23 Maran23 deleted the project-converter-declaring-inferring-types branch August 4, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion tool: exported variable types are incorrect
3 participants