Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a call to _shape() in the Label::_notification() to fix vertical space not being updated in one lined labels with word wrapping. #76058

Closed
wants to merge 1 commit into from
Closed

Added a call to _shape() in the Label::_notification() to fix vertical space not being updated in one lined labels with word wrapping. #76058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scene/gui/label.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,7 @@ void Label::_notification(int p_what) {

case NOTIFICATION_RESIZED: {
lines_dirty = true;
_shape();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be queue_redraw(); instead, processing text should not be necessary until control is displayed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queue_redraw() doesn't fix it! I tried before calling _shape()

} break;
}
}
Expand Down