Revert "Fix ShaderMaterial uniform type changes" #76535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #76438 and re-opens the issues.
That PR itself should be fine, but as currently some uniforms are created with a wrong type, that PR also clears a few valid type combinations when saving a ShaderMaterial.
I'll create that PR again after #74937 is merged, which should fix most incorrect uniform types. There might be also some need for a few backwards compatibility hacks, but I'll have to investigate that more. I might even have to combine both PR's so that all type updates happen at the same commit so that any fixups will work, too.