Fix ColorPicker position changing on theme update bug #76567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah setting offsets based on theme value is definitely not correct. |
|
Superseded by #78468. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62937 by no longer adding
theme_override_constants/marginto side offsets. It didn't seem to be working correctly anyway, only changing position in unexpected ways. It didn't even increase the space a ColorPicker takes up in a container (ex. HBoxContainer). Inside a container, it will still causepositionto change, which can lead to the ColorPicker moving outside of the container's rectangle entirely.Maybe
theme_override_constants/marginshould be removed entirely, not sure about how compatibility breaking it would be.