Add support for visualizing bones in Advanced Import Settings #76818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI "bugsquad edit" means an edit to another user's post by a member of Godot's bugsquad or bug triage team. So it doesn't make sense to use it in your own PRs ;) |
|
Oh! I thought it was to connect it to a proposal in the other repo |
TokageItLab
requested changes
May 8, 2023
fire
reviewed
May 24, 2023
TokageItLab
requested changes
May 25, 2023
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
3 times, most recently
from
8ce2e7e
to
5c6ae86
Compare
|
I added a struct to hold the materials but now is not passing the check |
fire
reviewed
May 25, 2023
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
3 times, most recently
from
f6a7ae8
to
74cc346
Compare
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
from
74cc346
to
130aedc
Compare
|
It is failing here: #12 0x55e24ea7773e in Ref<ShaderMaterial>::~Ref() (/home/runner/work/godot/godot/bin/godot.linuxbsd.editor.dev.double.x86_64.san+0x47a0a73e)
#13 0x55e2519078d0 in Skeleton3DGizmoPlugin::SelectionMaterials::~SelectionMaterials() (/home/runner/work/godot/godot/bin/godot.linuxbsd.editor.dev.double.x86_64.san+0x4a89a8d0) |
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
4 times, most recently
from
ce9cd67
to
786b5e1
Compare
|
oh oooooh...... since finally checks had passed I wanted to squash merge commits and my work..... I guess I kinda f** up right |
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
3 times, most recently
from
fa10d72
to
513b824
Compare
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
3 times, most recently
from
752d498
to
bbba3dd
Compare
…tings. When a node with the Skeleton3D type is selected, the bones are drawn using lines or octahedrons to provide a clearer reference to their position. Refactored Skeleton3DGizmoPlugin::redraw now uses a static function to generate bone meshes Update editor/import/scene_import_settings.cpp editor/import/scene_import_settings.h editor/plugins/skeleton_3d_editor_plugin.h editor/plugins/skeleton_3d_editor_plugin.cpp
jeronimo-schreyer
force-pushed
the
add_skeleton_mesh_in_3d_resource_importer
branch
from
bbba3dd
to
f79fc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for visualizing bones in Advanced Import Settings. When a node with the
Skeleton3Dtype is selected, the bones are drawn using lines or octahedrons to provide a clearer reference to their position.Update
editor/import/scene_import_settings.cpp
editor/import/scene_import_settings.h