Use WorkerThreadPool for Server threads #77004
Conversation
|
I think for GLES3 we need to take another approach as calling https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-wglmakecurrent Note: We actual call it every time we switch between a window for multi-window rendering right now which is not ideal. |
|
Maybe for GLES3 we can just always reserve the same thread of the threadpool so it can only be used for it and keep the others away. @RandomShaper what do you think? |
| } | ||
|
|
||
| main_thread = Thread::get_caller_id(); | ||
| main_thread = Thread::MAIN_ID; |
There was a problem hiding this comment.
This one can go away, can't it?
I'm not sure... If a thread is fully reserved, it can't do other work. If it's an affinity-like semantic, if GL work is needed when it's thread pool slot happens to be busy with something else, it will have to wait when maybe there are other free slots. Now I think of it, that can work as long as the thread pool only schedules non-GL work in the GL thread when all others are busy. |
reduz
force-pushed
the
use-worker-thread-pool-for-server-threading
branch
from
d2efed2
to
8435d32
Compare
|
You accidentally included a rebase conflict |
|
@AThousandShips oops.. well, I need to finish the PR anyway so I guess I will just push when its working again. |
reduz
force-pushed
the
use-worker-thread-pool-for-server-threading
branch
3 times, most recently
from
149737b
to
900dc33
Compare
* Servers now use WorkerThreadPool for background computation. * This helps keep the number of threads used fixed at all times. * It also ensures everything works on HTML5 with threads. * And makes it easier to support disabling threads for also HTML5. The only downside of this is that GLES3 threads likely no longer work because every time the render thread is called, the thread context is different. This needs to be researched how to fix. Maybe if GLES3 is used, threaded rendering server should be disabled for the time being?
reduz
force-pushed
the
use-worker-thread-pool-for-server-threading
branch
from
900dc33
to
30c92ca
Compare
|
Okay this is done, though it needs some more discussion (And potentially a small improvement to WorkerThreadPool from @RandomShaper). |
|
Superseded by #90268. |
The only downside of this is that GLES3 threads likely no longer work because every time the render thread is called, the thread context is different. This needs to be researched how to fix. Maybe if GLES3 is used, threaded rendering server should be disabled for the time being?