Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparisons were not correct, probably due to being cast to
String
and compared there (due to the casting not being explicit) but not clear how it was broken, but now it isn'tNow:
Fixes: #76218
Documentation handled by #77083
The alternative to this would be to change how the comparison is made by changing how it works in variant ops, but I think this is more elegant and doesn't break compat (for the non-broken comparisons), alternatively we could just remove the other comparisons
I feel keeping the pointer based comparisons is useful, doesn't add a lot of hacky fixes to avoid using the built-in operators on
StringName
(and the lack of any such method of comparison indicates to me that the pointer-based comparison was intended), and if you want unicode comparisons you can just cast it toString