Expose VideoStreamPlayer video length #77858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2023
akien-mga
reviewed
Jun 5, 2023
akien-mga
approved these changes
Jun 5, 2023
kinami-imai
force-pushed
the
expose_videostreamplayer_video_length
branch
from
a7335ec
to
e3da917
Compare
|
Force pushed changes by @akien-mga to keep git history clean 🙂 |
|
Thanks! |
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a group of three PRs (#77856 #77857 #77858) that solve godotengine/godot-proposals#264.
Currently, there is no way to determine the length of the video file being played in a VideoStreamPlayer. This PR exposes the get_length function of the VideoStreamPlayback to the VideoStreamPlayer in the editor. Right now this function returns 0 on Theora streams, however, GDExtension based VideoStreams may implement it.
In the future I might implement getting the length of Theora streams in a separate PR.