X11: Fix vformat ambiguous int types for GCC 10 (again) #77957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Jun 7, 2023
Comment on lines
869
to
+872
| "\n Major opcode of failed request: %d" | ||
| "\n Serial number of failed request: %d" | ||
| "\n Current serial number in output stream: %d", | ||
| String::utf8(message), error->request_code, error->minor_code, error->serial)); | ||
| String::utf8(message), (uint64_t)error->request_code, (uint64_t)error->minor_code, (uint64_t)error->serial)); |
There was a problem hiding this comment.
BTW, I'm not sure the descriptions are correct, comparing with https://www.x.org/releases/current/doc/man/man3/XErrorEvent.3.xhtml
request_code is indeed the major opcode, but are the description for the last two accurate?
"Serial number of failed request" seems to be the description of serial but we match it with minor_code.
CC @mxnemu
There was a problem hiding this comment.
I'm a bit out of it since I wrote it, but yeah it seems like the 2nd line should rather say "\n Minor opcode of failed request: %d"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup after #75099.
Same issue as we had to fix with 9dc2869. I don't reproduce it locally with GCC 12, I wonder if there's a way we can ensure to catch this from CI. Or whether we should add relevant definitions to disambiguate. @bruvzg
Edit: Ah it's failing specifically on x86_32 builds, which we don't test as often.