Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internally rename parent to collision_object in CollisionShape(2D/3D) #77971

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Internally rename parent to collision_object in CollisionShape(2D/3D) #77971

merged 1 commit into from
Jun 8, 2023

Conversation

aaronfranke
Copy link
Member

This is an internal rename to improve readability and clarity, split off from #77937 so we can merge this first.

@aaronfranke aaronfranke requested review from a team as code owners June 7, 2023 16:55
akien-mga
akien-mga approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aaronfranke
Copy link
Member Author

aaronfranke commented Jun 7, 2023 •
edited
Loading

Heads up: I added one more small cleanup to this PR to only get the parent once in get_configuration_warnings(), but GitHub is not showing that change in the PR due to an outage. View here.

@akien-mga akien-mga added this to the 4.1 milestone Jun 8, 2023
@akien-mga akien-mga merged commit a440f0d into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the col-shape-obj-name branch June 8, 2023 18:40
@aaronfranke aaronfranke mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:physics topic:2d topic:3d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronfranke @akien-mga