Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GLSL source-level debugging with RenderDoc #77975

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

sakrel
Copy link
Contributor

@sakrel sakrel commented Jun 7, 2023

This PR adds a command line argument (--generate-spirv-debug-info) that makes glslang embed additional debug info necessary for source-level debugging with RenderDoc.

See this presentation for more details: https://www.khronos.org/assets/uploads/developers/presentations/Source-level_Shader_Debugging_in_Vulkan_with_RenderDoc_VULOCT2022.pdf

https://renderdoc.org/docs/how/how_debug_shader.html

@sakrel sakrel requested review from a team as code owners June 7, 2023 18:18
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Let's go ahead with this for now and then we can rebase #78883 on top.

This is not suitable for cherrypicking.

@clayjohn clayjohn modified the milestones: 4.x, 4.2 Aug 15, 2023
@akien-mga akien-mga merged commit b44867b into godotengine:master Aug 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants