Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more basic tests for NavigationServer3D #78480

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Scony
Copy link
Contributor

@Scony Scony commented Jun 20, 2023

This PR adds simple tests for basic entity management, empty queries, setters, getters etc.

More serious tests will be added in the next PR.

@Scony Scony changed the title [WIP] Add more tests for 'NavigationServer3D' Add more basic tests for 'NavigationServer3D' Jun 21, 2023
@Scony Scony marked this pull request as ready for review June 21, 2023 17:49
@Scony Scony requested a review from a team as a code owner June 21, 2023 17:49
@Scony Scony mentioned this pull request Jun 21, 2023
63 tasks
@smix8 smix8 added this to the 4.2 milestone Jun 22, 2023
@Scony
Copy link
Contributor Author

Scony commented Jul 12, 2023

I think we can proceed with merging this :) It's just a bunch of tests.

@YuriSizov YuriSizov changed the title Add more basic tests for 'NavigationServer3D' Add more basic tests for NavigationServer3D Jul 14, 2023
@YuriSizov
Copy link
Contributor

@Scony Indeed we can. We only now started to merge 4.2-targeting PRs. Before we were merging 4.1.1-targeting PRs.

@YuriSizov YuriSizov merged commit 7e9d63e into godotengine:master Jul 14, 2023
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants