Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history mismatch #78827

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Jun 29, 2023

There are two cases for the error message, see #73603 (comment).

Set the properties of the resource's proxy instead of setting the resource's properties directly. (For action "Set ...")

Update the path of the edited scene when saving the scene. (For action "Add atlas source", see #73603 (comment))

Before

0.mp4

After

1.mp4

Fix #73603, fix #74594.

@akien-mga akien-mga requested review from groud and KoBeWi June 29, 2023 08:26
@akien-mga akien-mga added this to the 4.2 milestone Jun 29, 2023
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jun 29, 2023
editor/editor_node.cpp Outdated Show resolved Hide resolved
editor/editor_data.cpp Outdated Show resolved Hide resolved
Set the properties of the resource's proxy instead of setting the resource's
properties directly. (For action "Set ...")

Update the path of the edited scene when saving the scene. (For action "Add
atlas source")
@YuriSizov
Copy link
Contributor

@groud @KoBeWi Could you review this?

@YuriSizov YuriSizov merged commit bc0e646 into godotengine:master Jul 26, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@Rindbee Rindbee deleted the fix-history-mismatch branch July 27, 2023 00:47
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants