Fix error when non-ASCII characters in resource pack path #78935

timothyqiu · 2023-07-02T07:12:07Z

core/io/file_access_zip.cpp

akien-mga

Seems consistent with what's done in zip_io.cpp and other similar file opens.

akien-mga · 2023-07-07T08:05:14Z

Thanks!

YuriSizov · 2023-07-10T15:11:47Z

Cherry-picked for 4.1.1.

timothyqiu added bug topic:core cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 2, 2023

timothyqiu added this to the 4.2 milestone Jul 2, 2023

timothyqiu requested a review from a team as a code owner July 2, 2023 07:12

bruvzg reviewed Jul 2, 2023

View reviewed changes

core/io/file_access_zip.cpp Outdated Show resolved Hide resolved

Fix error when non-ASCII characters in resource pack path

df5c68a

timothyqiu force-pushed the zip-pack branch from 0085d41 to df5c68a Compare July 2, 2023 08:10

akien-mga approved these changes Jul 2, 2023

View reviewed changes

AThousandShips mentioned this pull request Jul 4, 2023

corrently parse utf8 from file_access_zip open #79038

Closed

akien-mga merged commit 5ee36d1 into godotengine:master Jul 7, 2023

YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023

timothyqiu deleted the zip-pack branch April 24, 2024 09:39

Provide feedback