Fix a typo in the String.to_float description
#78989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
approved these changes
Jul 3, 2023
YuriSizov
changed the title
String.to_float description
|
Thanks for opening a pull request! Please amend your commit message to state with a bit more detail what your commit does. E.g. "Fix a typo in the |
YuriSizov
added
cherrypick:4.0
cherrypick:4.1
|
Force pushed a rebase to remove the duplicate and merge commits. |
akien-mga
approved these changes
Jul 6, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix very minor typo in String class documentation, where an example for "to_float" has a "to_int" within it, despite also returning a float. Given these factors, this is likely a typo