Fix export options of scripted EditorExportPlugins
#79025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@RedworkDE The export options worked in #78958 because I've updated |
|
Ok, then this should indeed fix your issues (And also that change detection should then no longer be necessary in your PR) |
m4gr3d
added
topic:plugin
needs testing
topic:export
cherrypick:4.1
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #78958 (comment)
Not sure what the issue @m4gr3d has was, in my testing export options that are created by scripted export plugins, didn't work at all, unless the preset was created after enabling the plugin and only until the editor is restarted.
This PR ensures that the presets are updated after enabling/disabling export plugins, so that its options show up in/disappear from existing presets. Additionally this PR preserves the values of all options, even when they no longer exist, so that disabling a plugin doesn't cause its options to be lost. There is one exception to this in secret options, which will be dropped when the option no longer exists, to prefer loosing the secret over leaking it into the normal preset file when next saving the options.