Fix a typo in the TLSOptions documentation #79048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
changed the title
akien-mga
reviewed
Jul 5, 2023
doc/classes/TLSOptions.xml
Outdated
| @@ -29,15 +29,15 @@ | |||
| <description> | |||
| Creates a TLS client configuration which validates certificates and their common names (fully qualified domain names). | |||
| You can specify a custom [param trusted_chain] of certification authorities (the default CA list will be used if [code]null[/code]), and optionally provide a [param common_name_override] if you expect the certificate to have a common name other then the server FQDN. | |||
| Note: On the Web plafrom, TLS verification is always enforced against the CA list of the web browser. This is considered a security feature. | |||
| Note: On the Web platform, TLS verification is always enforced against the CA list of the web browser. This is considered a security feature. | |||
There was a problem hiding this comment.
While at it, it would be good to fix the style of "Note:" to be consistent with the rest of the docs. It should be "[b]Note:[/b] On the Web platform, ...".
|
There's another occurrence of this typo which would be good to fix in this commit too: |
akien-mga
reviewed
Jul 5, 2023
|
After fixing the indentation changes, could you squash the commits? See PR workflow for instructions. |
sepTN
force-pushed
the
its-platform-not-plafrom
branch
2 times, most recently
from
30a9f37
to
500944d
Compare
sepTN
force-pushed
the
its-platform-not-plafrom
branch
from
500944d
to
b88b6b4
Compare
akien-mga
approved these changes
Jul 8, 2023
akien-mga
added
the
cherrypick:4.1
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.