Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uid:// paths from external PCK files #79076

Closed
wants to merge 1 commit into from

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Jul 5, 2023

Closes godotengine/godot-proposals#7181

Because Godot now uses UIDs whenever possible, if these don't exist, warnings are generated. External scenes from PCK files can reference external UIDs not on the original project.

Since the uid_cache.bin is being force-exported anyways, this takes advantage of that fact by appending that information to the UID map.

String resource_cache_file = ResourceUID::get_cache_file();
if (FileAccess::exists(resource_cache_file)) {
files.push_back(resource_cache_file);
}

@rsubtil
Copy link
Contributor Author

rsubtil commented Mar 14, 2024

This was mostly superseeded by #82084, however that PR only fixes the issue for replacing packs.

Therefore, while this can be closed, a solution is still needed for non-replacing packs, which I'll experiment with and see if I can come up with a good approach.

@rsubtil rsubtil closed this Mar 14, 2024
@AThousandShips AThousandShips removed this from the 4.x milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support UID paths from PCK files
3 participants