Fill in descriptions for import options in the class reference #79405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Calinou
force-pushed
the
doc-import-options
branch
3 times, most recently
from
66f9c60
to
5f601b8
Compare
bruvzg
reviewed
Jul 13, 2023
Calinou
force-pushed
the
doc-import-options
branch
from
5f601b8
to
69b9032
Compare
bruvzg
reviewed
Jul 27, 2023
| </member> | ||
| <member name="fallbacks" type="Array" setter="" getter="" default="[]"> | ||
| List of font fallbacks to use if a glyph isn't found in this dynamic font. Fonts at the beginning of the array are attempted first, but fallback fonts that don't support the glyph's language and script are ignored (see [member language_support] and [member script_support]). See also [member allow_system_fallback]. |
There was a problem hiding this comment.
Suggested change
| List of font fallbacks to use if a glyph isn't found in this dynamic font. Fonts at the beginning of the array are attempted first, but fallback fonts that don't support the glyph's language and script are ignored (see [member language_support] and [member script_support]). See also [member allow_system_fallback]. | |
| List of font fallbacks to use if a glyph isn't found in this dynamic font. Fonts at the beginning of the array are attempted first, but fallback fonts that don't support the glyph's language and script are attempted last (see [member language_support] and [member script_support]). See also [member allow_system_fallback]. |
Procedure is like this, text server add each of the fallbacks to the one of 3 lists - language and script match, script match, no match. And do through them in the following order:
- Main font
- Language and script match list
- Script match list
- No match list
- System font (from
OS.get_system_font_path_for_text)
There was a problem hiding this comment.
I've applied the suggested change on Calinou's behalf to start the CI. I think for now it's good for merge (so it makes it into 4.2.dev2). If there are further clarifications or corrections required, we can open a follow-up PR.
YuriSizov
force-pushed
the
doc-import-options
branch
from
69b9032
to
bc58a8a
Compare
|
Thanks! |
aaronfranke
reviewed
Aug 1, 2023
| </member> | ||
| <member name="nodes/apply_root_scale" type="bool" setter="" getter="" default="true"> | ||
| If [code]true[/code], [member nodes/root_scale] will be applied on the meshes and animations directly, while keeping the root node's scale to the default [code](1, 1, 1)[/code]. This means that if you add a child node later on within the imported scene, it won't be scaled. If disabled, [member nodes/root_scale] will multiply the scale of the root node instead. |
There was a problem hiding this comment.
Note that I also adjusted these docs in #79774, I have rebased it and attempted to merge the doc changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully documents all editor import options currently exposed. (We are missing some options due to how they're registered, such as
slices/amountin ResourceImporterLayeredTexture andgltf/embedded_texture_handlingin EditorSceneFormatImporterGLTF.)